Support additional DNS names for clients-server TLS cert #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hvgirish
commented
Oct 4, 2021
| @@ -188,6 +188,10 @@ variable "jwt_ttl" { | |||
| default = "10m" | |||
| } | |||
|
|
|||
| variable "san_dns_names" { | |||
There was a problem hiding this comment.
This name sucks but I couldn't come up with a better name ¯_(ツ)_/¯
|
Cool 👍 Hopefully connecting via those alternate names will not create issues between the interaction of the etcd client and advertise address.. but we should be fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes it is desirable to have multiple DNS names to reach the same cluster. This adds support to specify a list of hostnames that the Server's client certs would include. Avoids the use of ETCDCTL_INSECURE_SKIP_TLS_VERIFY flag.