perf(next-international) improve caching and calls #337
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following code can become heavy with multiple keys and usage of scopes:
next-international/packages/next-international/src/common/create-t.ts
Lines 26 to 30 in 7887342
I think we can store all the plural keys after the first iteration so that we don't need to iterate over the keys anymore
On the following code :
next-international/packages/next-international/src/app/client/create-i18n-provider-client.tsx
Lines 27 to 31 in 7887342
The
Map.prototype.set
is returning the Map so we don't to check if thelocalesCache
haslocale
as a key because we already have this information with thelocalesCache.get