Component lifecycle methods #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geist-2501
commented
Jul 10, 2023
geist-2501
commented
Jul 10, 2023
Quillraven
requested changes
Jul 11, 2023
|
Thank you for your contribution! I have one minor remark about the test with the callback as system constructor argument. Should be possible to restructure the tests without using that. Please have a look and then we are ready to merge 😁 |
|
Replaced it with a much nicer getter in the test itself 👍 |
Quillraven
approved these changes
Jul 11, 2023
|
Cool, great stuff! I will make the SNAPSHOT release on maven tomorrow. And with that I will close the 2.4 features as well. I will do some testing on the weekend and if nothing crazy pops up, then we are good to go for the next stable release! Thank you again for the support 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds component lifecycle methods
onAddComponent()andonRemoveComponent, which replaces the component hooks. As such, this PR also removes component hooks.Discussion of this change can be found in issue #103.
The TL;DR of #103 is that lifecycle methods have are just a better developer experience over component hooks, with next to no performance hit.
Tests and code documentation have also been updated.
The removal of component hooks has resulted in slightly uglier tests, and I've pointed these out.