Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust auto-publishing workflow #108

Merged
merged 3 commits into from
Jul 17, 2023

Conversation

aSemy
Copy link
Contributor

@aSemy aSemy commented Jul 17, 2023

Adjust the 'publish' workflow so that it's called by the 'build' workflow as a reusable workflow

This hopefully fixes the issue described in #106

@aSemy : any idea why "Publish" workflow gets triggered for PRs? I thought the if condition in the job should prevent that? Obviously, I am wrong :D

Originally posted by @Quillraven in #106 (comment)

I'm not 100% certain that this will solve the issue, so please double check it!

@aSemy aSemy mentioned this pull request Jul 17, 2023
@aSemy aSemy force-pushed the fix/limit_auto_publish_workflow branch from e68d9af to c87d600 Compare July 17, 2023 09:57
@aSemy
Copy link
Contributor Author

aSemy commented Jul 17, 2023

Seems to work as expected for pull requests, so the publish workflow is skipped

image

Hopefully the publish workflow will be triggered correctly when 'build' runs on the master branch!

@aSemy
Copy link
Contributor Author

aSemy commented Jul 17, 2023

I see that the 'publish' workflow is still triggered: https://github.com/Quillraven/Fleks/actions/runs/5574312973/workflow

This is because GitHub is still picking up the unmodified publish.workflow that's on the master branch. The at 1336150 links to the master branch version: 1336150

image

I expect that the publish workflow will no longer be triggered when the 'build' workflow completes if this PR is merged is merged in.

Copy link
Owner

@Quillraven Quillraven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge it after the small change (if you agree) and then test it ;)

Thank you for your quick look into this issue.

.github/workflows/build.yml Outdated Show resolved Hide resolved
.github/workflows/build.yml Outdated Show resolved Hide resolved
@Quillraven Quillraven merged commit 579d696 into Quillraven:master Jul 17, 2023
4 checks passed
@aSemy aSemy deleted the fix/limit_auto_publish_workflow branch July 17, 2023 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants