Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ビルドとテストを実行するCI環境を整える #4

Closed
Hiroya-W opened this issue Sep 7, 2021 · 3 comments · Fixed by #7 or #10
Closed

ビルドとテストを実行するCI環境を整える #4

Hiroya-W opened this issue Sep 7, 2021 · 3 comments · Fixed by #7 or #10

Comments

@Hiroya-W
Copy link
Contributor

Hiroya-W commented Sep 7, 2021

  • isort + blackでフォーマットチェックする
  • flake8 + mypyで静的解析する
  • pytestでテストを実行する
@Hiroya-W
Copy link
Contributor Author

Hiroya-W commented Sep 7, 2021

isort + black + flake8 + mypyの細かい設定が大変そうなので、pysenで一元管理させてみる

@Hiroya-W
Copy link
Contributor Author

Hiroya-W commented Sep 7, 2021

とりあえず、適当なファイルを置いておいて、CIが通ることを確認する。開発進めばすぐ消していい

@Hiroya-W Hiroya-W mentioned this issue Sep 7, 2021
Merged
Hiroya-W added a commit that referenced this issue Sep 7, 2021
@Hiroya-W
Merge pull request #7 from Qulacs-Osaka/04-setup-ci
efc79e0 
CIのSetup #4
@Hiroya-W Hiroya-W reopened this Sep 7, 2021
@Hiroya-W
Copy link
Contributor Author

Hiroya-W commented Sep 7, 2021

CIでformatしてからlintチェックすると、formatされてないことを検出出来ないので、lintチェックだけでいい
pysenでは、lintチェックでformatチェックされる

@Hiroya-W Hiroya-W mentioned this issue Sep 7, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

CIのSetup #4 Qulacs-Osaka/qulacs-visualizer
Fix format check Qulacs-Osaka/qulacs-visualizer
1 participant
@Hiroya-W