Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use gate.name when LaTeX-style string is unavailable #113

Merged
merged 1 commit into from
Jun 15, 2023
Merged

Use gate.name when LaTeX-style string is unavailable #113

merged 1 commit into from
Jun 15, 2023

Conversation

kwkbtr
Copy link
Contributor

@kwkbtr kwkbtr commented Jun 2, 2023

I wanted to draw a gate whose name is not included in the standard LaTeX-style name mapping, so I made a change to catch KeyError and fallback to the original gate.name.

Hiroya-W
Hiroya-W approved these changes Jun 8, 2023
View reviewed changes
Copy link
Contributor

@Hiroya-W Hiroya-W left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM！

@Hiroya-W Hiroya-W merged commit 64f713e into Qulacs-Osaka:main Jun 15, 2023
@kwkbtr kwkbtr deleted the catch_latex_error branch June 16, 2023 07:16
@Hiroya-W Hiroya-W mentioned this pull request Jun 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hiroya-W Hiroya-W Hiroya-W approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kwkbtr @Hiroya-W