update pyproject.toml #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should I also update `poetry.lock` ?
Hiroya-W
reviewed
Oct 13, 2022
There was a problem hiding this comment.
@terasakisatoshi PRありがとうございます！Issueを確認して、手元でも再現しました。
もしpoetryを使って作業が出来そうであれば、poetry.lockも更新していただけますか？pyproject.tomlの変更に合わせてpoetry.lockのメタデータが変わる部分があるので、同時に変更出来れば嬉しいです
Hiroya-W
approved these changes
Oct 18, 2022
|
バグレポートありがとうございました！ |
terasakisatoshi
deleted the
move-dataclasses-json-to-dependencies-not-dev
branch
|
レビューありがとうございました😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve #87
Should I also update
poetry.lock?