feat: expose array-like methods for searching data #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matt-forster
suggested changes
Aug 4, 2020
trs
force-pushed
the
array-like-methods
branch
3 times, most recently
from
3356bb9 to
2464c38
Compare
trs
commented
Aug 4, 2020
Comment on lines
+92
to
+93
| cityData.name, | ||
| cityData.province, |
There was a problem hiding this comment.
The data was manipulated to make the specific implementation of text search easier. But with that gone, I think it makes sense to expose these as-is.
Instead of limiting an end-user to a string search, enable `predicate` functions to `find` and `filter` values. BREAKING CHANGE: exposed api changed from string search to predicate methods
Co-authored-by: forstermatth <matt@autovance.com>
matt-forster
approved these changes
Aug 4, 2020
matt-forster
reviewed
Aug 4, 2020
| @@ -1,13 +1,12 @@ | |||
| { | |||
| "name": "canadian-city-timezones", | |||
| "version": "1.0.0", | |||
| "version": "2.0.0", | |||
There was a problem hiding this comment.
If semver has been set up, do we need to change this?
There was a problem hiding this comment.
Not at all! Could even make it 0.0.0 or something.
|
🎉 This PR is included in version 2.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of limiting an end-user to a string search, enable
predicatefunctions tofindandfiltervalues.BREAKING CHANGE: exposed api changed from string search to predicate methods