-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow dynamic pasv_url depending on remote address #269
Conversation
Hello! any chance to have this merged? |
@vdiez Hi, thanks for the contribution! Just letting you know this isn't falling on deaf ears - I'll take a look! |
I'd definitely like some docs included in this PR if we are going to accept this - as it would be a shadow feature otherwise. |
I think, for the last thing before this is accepted (awesome work, btw) - we need to include some information in the docs. We will want to expand this section with the fact that it can now be a function, and that the function should also take into account local connection logic if needed. https://github.com/autovance/ftp-srv/blob/master/README.md?plain=1#L75-L77 |
Thanks! Just added some explanations and an example which I hope clarifies the utility of this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Some improvement to the docs to ensure we show clear JS, and we can include JS highlighting as well!
🎉 This PR is included in version 4.5.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
thanks! |
Allow passing a function to pasv_url with the remote IP of the client, so that we can flexibly decide what is the correct passive URL to use. Useful if we want an FTP to be used from different networks (Intranet and internet for example)