Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow dynamic pasv_url depending on remote address #269

Merged
merged 9 commits into from
Aug 9, 2021
Merged

feat: allow dynamic pasv_url depending on remote address #269

merged 9 commits into from
Aug 9, 2021

Conversation

vdiez
Copy link
Contributor

@vdiez vdiez commented Jul 23, 2021

Allow passing a function to pasv_url with the remote IP of the client, so that we can flexibly decide what is the correct passive URL to use. Useful if we want an FTP to be used from different networks (Intranet and internet for example)

@vdiez
Copy link
Contributor Author

vdiez commented Aug 4, 2021

Hello! any chance to have this merged?

@matt-forster
Copy link
Contributor

@vdiez Hi, thanks for the contribution! Just letting you know this isn't falling on deaf ears - I'll take a look!

@matt-forster matt-forster self-assigned this Aug 9, 2021
@matt-forster
Copy link
Contributor

I'd definitely like some docs included in this PR if we are going to accept this - as it would be a shadow feature otherwise.

src/commands/registration/pasv.js Outdated Show resolved Hide resolved
src/commands/registration/pasv.js Outdated Show resolved Hide resolved
src/commands/registration/pasv.js Outdated Show resolved Hide resolved
src/commands/registration/pasv.js Show resolved Hide resolved
@matt-forster
Copy link
Contributor

matt-forster commented Aug 9, 2021

I think, for the last thing before this is accepted (awesome work, btw) - we need to include some information in the docs.

We will want to expand this section with the fact that it can now be a function, and that the function should also take into account local connection logic if needed.

https://github.com/autovance/ftp-srv/blob/master/README.md?plain=1#L75-L77

@vdiez
Copy link
Contributor Author

vdiez commented Aug 9, 2021

Thanks! Just added some explanations and an example which I hope clarifies the utility of this.

matt-forster
matt-forster previously approved these changes Aug 9, 2021
Copy link
Contributor

@matt-forster matt-forster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Some improvement to the docs to ensure we show clear JS, and we can include JS highlighting as well!

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
@matt-forster matt-forster merged commit 02227d6 into QuorumDMS:master Aug 9, 2021
@botovance
Copy link
Contributor

🎉 This PR is included in version 4.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@vdiez
Copy link
Contributor Author

vdiez commented Aug 9, 2021

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants