Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(optimizer): nicer module finding + fix dev #6556

Merged
merged 1 commit into from
Jun 17, 2024
Merged

refactor(optimizer): nicer module finding + fix dev #6556

merged 1 commit into from
Jun 17, 2024

Conversation

wmertens
Copy link
Member

@wmertens wmertens commented Jun 16, 2024

  • refactored manifest generation
  • dev server collects QRL parents during ssr build
  • optimizer also stores dev info for noop QRLs
  • dev server also uses dev info as an extra fallback
  • dev source URLs are kept similar looking to the source tree
  • QRLs are annotated with parent so they can be built on demand

@wmertens wmertens requested review from a team as code owners June 16, 2024 18:59
Copy link

netlify bot commented Jun 16, 2024

Deploy Preview for qwik-insights ready!

Name Link
🔨 Latest commit 993a22f
🔍 Latest deploy log https://app.netlify.com/sites/qwik-insights/deploys/667035ce68fc8c00082035dc
😎 Deploy Preview https://deploy-preview-6556--qwik-insights.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

pkg-pr-new bot commented Jun 16, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

commit: 993a22f

@builder.io/qwik

npm i https://pkg.pr.new/@builder.io/qwik@6556

@builder.io/qwik-city

npm i https://pkg.pr.new/@builder.io/qwik-city@6556

eslint-plugin-qwik

npm i https://pkg.pr.new/eslint-plugin-qwik@6556

create-qwik

npm i https://pkg.pr.new/create-qwik@6556

Copy link

cloudflare-workers-and-pages bot commented Jun 16, 2024

Deploying qwik-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 993a22f
Status: ✅  Deploy successful!
Preview URL: https://a3c9cf3a.qwik-8nx.pages.dev
Branch Preview URL: https://fix-dev.qwik-8nx.pages.dev

View logs

gioboa
gioboa previously approved these changes Jun 16, 2024
Copy link
Member

@gioboa gioboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look great to me 👍

packages/qwik/src/core/qrl/qrl.ts Outdated Show resolved Hide resolved
packages/qwik/src/optimizer/src/manifest.ts Outdated Show resolved Hide resolved
packages/qwik/src/optimizer/src/manifest.ts Outdated Show resolved Hide resolved
- refactored manifest generation
- dev server collects QRL parents during ssr build
- optimizer also stores dev info for noop QRLs
- dev server also uses dev info as an extra fallback
- dev source URLs are kept similar looking to the source tree
- QRLs are annotated with parent so they can be built on demand
@wmertens wmertens changed the title refactor(optimizer): more robust module finding refactor(optimizer): nicer module finding + fix dev Jun 17, 2024
@wmertens wmertens enabled auto-merge (squash) June 17, 2024 14:16
@wmertens wmertens disabled auto-merge June 17, 2024 20:23
@wmertens wmertens merged commit b35665d into main Jun 17, 2024
31 checks passed
@wmertens wmertens deleted the fix-dev branch June 17, 2024 20:24
genki pushed a commit to genki/qwik that referenced this pull request Jun 28, 2024
- refactored manifest generation
- dev server collects QRL parents during ssr build
- optimizer also stores dev info for noop QRLs
- dev server also uses dev info as an extra fallback
- dev source URLs are kept similar looking to the source tree
- QRLs are annotated with parent so they can be built on demand
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants