Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(state): add guidance on signals as props #6574

Merged
merged 3 commits into from
Jun 20, 2024
Merged

Conversation

shairez
Copy link
Contributor

@shairez shairez commented Jun 19, 2024

Overview

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests / types / typos

Description

Will help people to use qwik's best practices and save them time

Checklist:

  • My code follows the developer guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • Added new tests to cover the fix / functionality

@shairez shairez requested a review from a team as a code owner June 19, 2024 10:49
Copy link

netlify bot commented Jun 19, 2024

Deploy Preview for qwik-insights ready!

Name Link
🔨 Latest commit ef2a4d9
🔍 Latest deploy log https://app.netlify.com/sites/qwik-insights/deploys/66734d280eedf80008b052bf
😎 Deploy Preview https://deploy-preview-6574--qwik-insights.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

pkg-pr-new bot commented Jun 19, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

commit: ef2a4d9

@builder.io/qwik

npm i https://pkg.pr.new/@builder.io/qwik@6574

@builder.io/qwik-city

npm i https://pkg.pr.new/@builder.io/qwik-city@6574

eslint-plugin-qwik

npm i https://pkg.pr.new/eslint-plugin-qwik@6574

create-qwik

npm i https://pkg.pr.new/create-qwik@6574

Copy link

cloudflare-workers-and-pages bot commented Jun 19, 2024

Deploying qwik-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: ef2a4d9
Status: ✅  Deploy successful!
Preview URL: https://fb603b1b.qwik-8nx.pages.dev
Branch Preview URL: https://shairez-patch-1.qwik-8nx.pages.dev

View logs

gioboa
gioboa previously approved these changes Jun 19, 2024
Copy link
Member

@gioboa gioboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great @shairez

@PatrickJS PatrickJS merged commit e2b6895 into main Jun 20, 2024
29 checks passed
@PatrickJS PatrickJS deleted the shairez-patch-1 branch June 20, 2024 10:40
genki pushed a commit to genki/qwik that referenced this pull request Jun 28, 2024
Co-authored-by: Giorgio Boa <35845425+gioboa@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants