Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(qrl): wrap resolved funcs for scope #6575

Merged
merged 1 commit into from
Jun 20, 2024
Merged

feat(qrl): wrap resolved funcs for scope #6575

merged 1 commit into from
Jun 20, 2024

Conversation

wmertens
Copy link
Member

@wmertens wmertens commented Jun 19, 2024

  • now you can call the result of .resolve() (and .resolved) directly
  • avoids wrapping QRL functions that don't use lexical scope
  • moves symbol load event to resolve(), only when it needed to get it externally

- now you can call the result of `.resolve()` (and `.resolved`) directly
- avoids wrapping QRL functions that don't use lexical scope
@wmertens wmertens requested a review from a team as a code owner June 19, 2024 12:06
Copy link

netlify bot commented Jun 19, 2024

Deploy Preview for qwik-insights ready!

Name Link
🔨 Latest commit 2355ec8
🔍 Latest deploy log https://app.netlify.com/sites/qwik-insights/deploys/6672c9decd50250008c201c5
😎 Deploy Preview https://deploy-preview-6575--qwik-insights.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

pkg-pr-new bot commented Jun 19, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

commit: 2355ec8

@builder.io/qwik

npm i https://pkg.pr.new/@builder.io/qwik@6575

@builder.io/qwik-city

npm i https://pkg.pr.new/@builder.io/qwik-city@6575

eslint-plugin-qwik

npm i https://pkg.pr.new/eslint-plugin-qwik@6575

create-qwik

npm i https://pkg.pr.new/create-qwik@6575

Copy link

Deploying qwik-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 2355ec8
Status:🚫  Build failed.

View logs

@wmertens wmertens merged commit 7b6eab6 into main Jun 20, 2024
29 of 30 checks passed
@wmertens wmertens deleted the do branch June 20, 2024 04:51
genki pushed a commit to genki/qwik that referenced this pull request Jun 28, 2024
- now you can call the result of `.resolve()` (and `.resolved`) directly
- avoids wrapping QRL functions that don't use lexical scope
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants