fix: moved express to dependencies section

[thecoder93]

Overview

Moved express to dependencies section

What is it?

• Feature / enhancement
• Bug
• Docs / tests / types / typos

Description

Express should be under dependencies

Use cases and why

• 1. One use case
• 2. Another use case

Checklist:

• My code follows the developer guidelines of this project
• I have performed a self-review of my own code
• I have made corresponding changes to the documentation
• Added new tests to cover the fix / functionality

[netlify]

👷 Deploy request for qwik-insights pending review.

Visit the deploys page to approve it

Name	Link
🔨 Latest commit	ceeaf68

[pkg-pr-new]

Run & review this pull request in StackBlitz Codeflow.

commit: ceeaf68

@builder.io/qwik

npm i https://pkg.pr.new/@builder.io/qwik@6576

@builder.io/qwik-city

npm i https://pkg.pr.new/@builder.io/qwik-city@6576

eslint-plugin-qwik

npm i https://pkg.pr.new/eslint-plugin-qwik@6576

create-qwik

npm i https://pkg.pr.new/create-qwik@6576

[gioboa]

That's great @thecoder93 Thanks

[wmertens]

@thecoder93 @gioboa IMHO express should be in devdependencies, but only if vite is configured to bundle it into the server bundle.

We had it configured like that, which is why it was not in dependencies.

However that caused confusion when people mixed deps and devDeps. I'm not sure what the configuration is now.

@PatrickJS ?

[nelsonprsousa]

@thecoder93 @gioboa IMHO express should be in devdependencies, but only if vite is configured to bundle it into the server bundle.

We had it configured like that, which is why it was not in dependencies.

However that caused confusion when people mixed deps and devDeps. I'm not sure what the configuration is now.

@PatrickJS ?

Where can we learn more about dependencies vs devDependencies while working with qwik/vite? For me it looks strange to not have express as a dependency if it is the main entry for production?!