Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: moved Fastify packages to dependencies section #6577

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

thecoder93
Copy link
Contributor

Overview

Moved fastify to dependencies section

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests / types / typos

Description

Fastify should be under dependencies. Here the issue:

#5795

Use cases and why

    1. One use case
    1. Another use case

Checklist:

  • My code follows the developer guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • Added new tests to cover the fix / functionality

@thecoder93 thecoder93 requested a review from a team as a code owner June 19, 2024 13:16
Copy link

netlify bot commented Jun 19, 2024

👷 Deploy request for qwik-insights pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 03e09bb

Copy link

pkg-pr-new bot commented Jun 19, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

commit: 03e09bb

@builder.io/qwik

npm i https://pkg.pr.new/@builder.io/qwik@6577

@builder.io/qwik-city

npm i https://pkg.pr.new/@builder.io/qwik-city@6577

eslint-plugin-qwik

npm i https://pkg.pr.new/eslint-plugin-qwik@6577

create-qwik

npm i https://pkg.pr.new/create-qwik@6577

@gioboa gioboa linked an issue Jun 19, 2024 that may be closed by this pull request
Copy link
Member

@gioboa gioboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me @thecoder93 thanks

@gioboa gioboa merged commit 490b0d6 into QwikDev:main Jun 19, 2024
20 checks passed
genki pushed a commit to genki/qwik that referenced this pull request Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🐞]deployments (node): refactor express and fastify inputs
2 participants