fix(qrl): correct qrl loading in vite dev mode #6579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for qwik-insights ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
commit: @builder.io/qwik
@builder.io/qwik-city
eslint-plugin-qwik
create-qwik
|
Deploying qwik-docs with
|
| Latest commit: |
a7073d3
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://0d9aed22.qwik-8nx.pages.dev |
| Branch Preview URL: | https://fix-dev-qrl.qwik-8nx.pages.dev |
gioboa
approved these changes
Jun 19, 2024
|
Can you provide a short description to keep track of these changes in the long-term? |
PatrickJS
reviewed
Jun 20, 2024
| @@ -14,7 +14,7 @@ import { $ } from '@builder.io/qwik'; | |||
| // - Robust, fully relies only on history. (scrollRestoration = 'manual') | |||
|
|
|||
| // ! DO NOT IMPORT OR USE ANY EXTERNAL REFERENCES IN THIS SCRIPT. | |||
| export default $((container: HTMLElement) => { | |||
There was a problem hiding this comment.
haha good use-case for event$
PatrickJS
approved these changes
Jun 20, 2024
genki
pushed a commit
to genki/qwik
that referenced
this pull request
Jun 28, 2024
Co-authored-by: Giorgio Boa <35845425+gioboa@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Qwik city preloaded spa-init.ts but that didn't include the parent info so it gave a harmless error.
Also, qrl paths with + turned into spaces, which broke loading