Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(qrl): correct qrl loading in vite dev mode #6579

Merged
merged 2 commits into from
Jun 20, 2024
Merged

fix(qrl): correct qrl loading in vite dev mode #6579

merged 2 commits into from
Jun 20, 2024

Conversation

wmertens
Copy link
Member

@wmertens wmertens commented Jun 19, 2024

Qwik city preloaded spa-init.ts but that didn't include the parent info so it gave a harmless error.
Also, qrl paths with + turned into spaces, which broke loading

@wmertens wmertens requested a review from a team as a code owner June 19, 2024 18:57
@wmertens wmertens enabled auto-merge (squash) June 19, 2024 18:57
Copy link

netlify bot commented Jun 19, 2024

Deploy Preview for qwik-insights ready!

Name Link
🔨 Latest commit a7073d3
🔍 Latest deploy log https://app.netlify.com/sites/qwik-insights/deploys/66734bf46fe4320008af3e89
😎 Deploy Preview https://deploy-preview-6579--qwik-insights.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

pkg-pr-new bot commented Jun 19, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

commit: a7073d3

@builder.io/qwik

npm i https://pkg.pr.new/@builder.io/qwik@6579

@builder.io/qwik-city

npm i https://pkg.pr.new/@builder.io/qwik-city@6579

eslint-plugin-qwik

npm i https://pkg.pr.new/eslint-plugin-qwik@6579

create-qwik

npm i https://pkg.pr.new/create-qwik@6579

Copy link

cloudflare-workers-and-pages bot commented Jun 19, 2024

Deploying qwik-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: a7073d3
Status: ✅  Deploy successful!
Preview URL: https://0d9aed22.qwik-8nx.pages.dev
Branch Preview URL: https://fix-dev-qrl.qwik-8nx.pages.dev

View logs

@gioboa
Copy link
Member

gioboa commented Jun 19, 2024

Can you provide a short description to keep track of these changes in the long-term?
Looks good to me 👏

@@ -14,7 +14,7 @@ import { $ } from '@builder.io/qwik';
// - Robust, fully relies only on history. (scrollRestoration = 'manual')

// ! DO NOT IMPORT OR USE ANY EXTERNAL REFERENCES IN THIS SCRIPT.
export default $((container: HTMLElement) => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

haha good use-case for event$

@wmertens wmertens merged commit 96ae4c6 into main Jun 20, 2024
30 checks passed
@wmertens wmertens deleted the fix-dev-qrl branch June 20, 2024 00:48
genki pushed a commit to genki/qwik that referenced this pull request Jun 28, 2024
Co-authored-by: Giorgio Boa <35845425+gioboa@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants