Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(qwikVite): multiple outputs logic #6723

Merged
merged 1 commit into from
Jul 28, 2024

Conversation

KingSora
Copy link
Contributor

Overview

Fixes #6620 and retains #6452. Successor of #6643.

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests / types / typos

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Use cases and why

    1. One use case
    1. Another use case

Checklist:

  • My code follows the developer guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • Added new tests to cover the fix / functionality

@KingSora KingSora requested a review from a team as a code owner July 26, 2024 08:40
Copy link

changeset-bot bot commented Jul 26, 2024

⚠️ No Changeset found

Latest commit: deb8724

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR
Some errors occurred when validating the changesets config:
The package or glob expression "qwik-monorepo" specified in the `fixed` option does not match any package in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.

Copy link

netlify bot commented Jul 26, 2024

‼️ Deploy request for qwik-insights rejected.

Name Link
🔨 Latest commit deb8724

Copy link

pkg-pr-new bot commented Jul 26, 2024

commit: deb8724

npm i https://pkg.pr.new/@builder.io/qwik@6723
npm i https://pkg.pr.new/@builder.io/qwik-city@6723
npm i https://pkg.pr.new/eslint-plugin-qwik@6723
npm i https://pkg.pr.new/create-qwik@6723

Open in Stackblitz

@shairez
Copy link
Contributor

shairez commented Jul 28, 2024

Thanks @KingSora

@wmertens can you review please? 🙏

Copy link
Member

@wmertens wmertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@wmertens wmertens merged commit fb59aa6 into QwikDev:main Jul 28, 2024
18 of 20 checks passed
@wmertens
Copy link
Member

Thanks @KingSora !

maiieul added a commit to maiieul/qwik that referenced this pull request Aug 27, 2024
maiieul added a commit to maiieul/qwik that referenced this pull request Aug 27, 2024
maiieul added a commit to maiieul/qwik that referenced this pull request Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🐞] image optimizer with imagetools in cloudflare addressed wrong srcset
3 participants