Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add migrate-v2 command #6810

Draft
wants to merge 2 commits into
base: build/v2
Choose a base branch
from
Draft

feat: add migrate-v2 command #6810

wants to merge 2 commits into from
+474 −1

Conversation

dmitry-stepanenko
Copy link
Contributor

No description provided.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Aug 20, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 14cfecf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dmitry-stepanenko dmitry-stepanenko force-pushed the ds/cli-migrate-v2-cmd branch 2 times, most recently from 4efe0ac to e6230a1 Compare August 20, 2024 17:09
@shairez shairez mentioned this pull request Sep 4, 2024
Open
@dmitry-stepanenko dmitry-stepanenko force-pushed the ds/cli-migrate-v2-cmd branch 5 times, most recently from bb0671a to 4e89e10 Compare September 8, 2024 10:17
@dmitry-stepanenko dmitry-stepanenko force-pushed the ds/cli-migrate-v2-cmd branch 2 times, most recently from a2818aa to 2e4bedd Compare September 8, 2024 11:55
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Sep 8, 2024 •
edited
Loading

Open in Stackblitz

npm i https://pkg.pr.new/@builder.io/qwik@6810

npm i https://pkg.pr.new/@builder.io/qwik-city@6810

npm i https://pkg.pr.new/eslint-plugin-qwik@6810

npm i https://pkg.pr.new/create-qwik@6810

commit: 2e4bedd

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 8, 2024 •
edited
Loading

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview 14cfecf

@shairez
Copy link
Contributor

shairez commented Oct 28, 2024

@dmitry-stepanenko the new package for city is @qwik.dev/router 😊

ianlet
ianlet reviewed Oct 28, 2024
View reviewed changes
packages/qwik/src/cli/migrate-v2/run-migration.ts

try {
replacePackage('@builder.io/qwik-city', '@qwik.dev/city', versions['@qwik.dev/city']);
replacePackage('@builder.io/qwik', '@qwik.dev/qwik', versions['@qwik.dev/qwik']);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we add @builder.io/qwik-auth -> @auth/core as well? considering it was removed in v2

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes please add

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shairez anything related to qwik-labs or other packages to add here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so... I think qwik-auth should be migrated to @auth/qwik but there are a bunch of extra migration steps for that, so I don't know if we want to get into that via this script.

Regarding qwik-labs, all of its features have been folded into either core or router.
But the only used one I know of is insights.

I've documented its changes here -
#7018

again, it's not widely used, so I don't know if it worth the effort to make it automatic like the other more used ones.

@ianlet
Copy link
Contributor

ianlet commented Oct 31, 2024 •
edited
Loading

Edit: actually, I'll keep updating this list with what I had to change manually

Deprecated stuff that I renamed without any other changes:

  • QwikCityProvider ➡️ QwikRouterProvider
  • qwikCity ➡️ qwikRouter (in vite.config.ts plugins)

@shairez
Copy link
Contributor

shairez commented Oct 31, 2024

Thanks @ianlet !

FYI qwik-react was renamed to @qwik.dev/react

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PatrickJS PatrickJS PatrickJS left review comments

@shairez shairez shairez left review comments

@ianlet ianlet ianlet left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dmitry-stepanenko @shairez @ianlet @PatrickJS