Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resource internal error #6912

Closed
wants to merge 6 commits into from

Conversation

JerryWu1234
Copy link
Contributor

image
image

v1 and v2

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests / types / typos
  • Infra

Description

Checklist:

  • My code follows the developer guidelines of this project
  • I have performed a self-review of my own code
  • I have ran pnpm change and documented my changes
  • I have made corresponding changes to the Qwik docs
  • Added new tests to cover the fix / functionality

@JerryWu1234 JerryWu1234 requested review from a team as code owners September 26, 2024 05:34
Copy link

changeset-bot bot commented Sep 26, 2024

🦋 Changeset detected

Latest commit: 49c9131

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@builder.io/qwik Minor
eslint-plugin-qwik Minor
@builder.io/qwik-city Minor
create-qwik Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Sep 26, 2024

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview 49c9131

Copy link
Contributor

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs 🔨 Building (View Log) 743f40a

@JerryWu1234
Copy link
Contributor Author

@Varixo please help check this PR

const abortController = new AbortController();
cleanup(() => abortController.abort('cleanup'));
const controller = new AbortController();
cleanup(() => controller.abort());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand what the problem is - is it because of the 'cleanup' string?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think these changes actually fix the issue as they are not related to the demo that fails.

Have a look at this PR instead: #6893.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand what the problem is - is it because of the 'cleanup' string?

Yes because of the ‘cleanup’ string. It's weird but I'm still digging into it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think these changes actually fix the issue as they are not related to the demo that fails.

Have a look at this PR instead: #6893.

You can try it by my code if you don't believe that can fix it.
And I have already shown my picture that everything is ok.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This issue doesn't occur locally, that's why the screenshots show that everything is ok.

Everything works locally even with the clean up string passed to the abort controller.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you are right, my bad.
I will close this PR.

@JerryWu1234 JerryWu1234 closed this Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants