-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resource internal error #6912
Resource internal error #6912
Conversation
🦋 Changeset detectedLatest commit: 49c9131 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
@Varixo please help check this PR |
const abortController = new AbortController(); | ||
cleanup(() => abortController.abort('cleanup')); | ||
const controller = new AbortController(); | ||
cleanup(() => controller.abort()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand what the problem is - is it because of the 'cleanup' string?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think these changes actually fix the issue as they are not related to the demo that fails.
Have a look at this PR instead: #6893.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand what the problem is - is it because of the 'cleanup' string?
Yes because of the ‘cleanup’ string. It's weird but I'm still digging into it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think these changes actually fix the issue as they are not related to the demo that fails.
Have a look at this PR instead: #6893.
You can try it by my code if you don't believe that can fix it.
And I have already shown my picture that everything is ok.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This issue doesn't occur locally, that's why the screenshots show that everything is ok.
Everything works locally even with the clean up
string passed to the abort controller.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you are right, my bad.
I will close this PR.
v1 and v2
What is it?
Description
Checklist:
pnpm change
and documented my changes