Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(qwik-auth) update dependencies due to security alert #6994

Closed

Conversation

tzdesign
Copy link
Contributor

the cookie package had a validation issue see jshttp/cookie#167

the cookie package had a validation issue see jshttp/cookie#167
@tzdesign tzdesign requested review from a team as code owners October 22, 2024 13:05
Copy link

changeset-bot bot commented Oct 22, 2024

⚠️ No Changeset found

Latest commit: 8cc75a6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

pkg-pr-new bot commented Oct 22, 2024

Open in Stackblitz

npm i https://pkg.pr.new/@builder.io/qwik@6994
npm i https://pkg.pr.new/@builder.io/qwik-city@6994
npm i https://pkg.pr.new/eslint-plugin-qwik@6994
npm i https://pkg.pr.new/create-qwik@6994

commit: 8cc75a6

Copy link
Contributor

github-actions bot commented Oct 22, 2024

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview 8cc75a6

@tzdesign tzdesign marked this pull request as draft October 22, 2024 14:50
@tzdesign tzdesign marked this pull request as ready for review October 22, 2024 15:13
@ianlet
Copy link
Contributor

ianlet commented Oct 25, 2024

Thanks for this update @tzdesign 🙌

qwik-auth is deprecated and should be replaced by https://www.npmjs.com/package/@auth/qwik. So it would be better if you update your project to use this package instead. That way, you can benefit from security fixes and other patches.

@tzdesign
Copy link
Contributor Author

@ianlet why don't we remove it from the monorepo?

@ianlet
Copy link
Contributor

ianlet commented Oct 28, 2024

@tzdesign it was removed in v2. So as soon as v2 is released it won't be an issue anymore.

@shairez
Copy link
Contributor

shairez commented Oct 28, 2024

thanks @tzdesign

Yeah, as @ianlet said, this is package has been removed from the monorepo in V2, so closing this PR for now

If you think there's a good reason to merge this, let me know and I will

@shairez shairez closed this Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants