Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix docs build and exporting insights #6997

Merged
merged 2 commits into from
Oct 25, 2024
Merged

fix: fix docs build and exporting insights #6997

merged 2 commits into from
Oct 25, 2024

Conversation

Varixo
Copy link
Member

@Varixo Varixo commented Oct 25, 2024

Fix docs build and exporting insights

@Varixo Varixo self-assigned this Oct 25, 2024
@Varixo Varixo requested review from a team as code owners October 25, 2024 13:34
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 25, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 9d1955c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Oct 25, 2024

Open in Stackblitz

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/core@6997

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/city@6997

npm i https://pkg.pr.new/QwikDev/qwik/eslint-plugin-qwik@6997

npm i https://pkg.pr.new/QwikDev/qwik/create-qwik@6997

commit: c704e87

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 25, 2024 •
edited
Loading

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview 9d1955c

@Varixo Varixo marked this pull request as draft October 25, 2024 13:53
@Varixo Varixo marked this pull request as ready for review October 25, 2024 14:06
wmertens
wmertens approved these changes Oct 25, 2024
View reviewed changes
Copy link
Member

@wmertens wmertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wmertens wmertens merged commit 4dd471d into build/v2 Oct 25, 2024
14 checks passed
@wmertens wmertens deleted the v2-fix-docs-insights branch October 25, 2024 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wmertens wmertens wmertens approved these changes

Assignees

@Varixo Varixo

Labels
VERSION: upcoming major
Projects
Qwik Development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Varixo @wmertens