-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added public endpoint for fetching subset of projects info #923
Conversation
Nice work @this-Aditya, Some thoughts, feel free to override:
I guess I just logically group this with Project a little more than is done in the current implementation. If others disagree (@yatharthranjan @mpgxvii) feel free to approve and move forward |
Thanks for the review, @Bdegraaf1234 ! |
Yeah that might be an issue, I think it would be good to check with if someone knows where we use the Are you in the SEP meeting later today? Would be good to discuss this there |
Okay, fine. I don't have an invite for that meeting. Could you please share the link on Slack? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with most of Bastiaan's suggestions. Adding a new DTO instead of extending the previous one is acceptable, as this has a specific public use case. The previous one improved performance for the MP's home page (for logged-in users).
@Bdegraaf1234 I think the SEP meeting is cancelled today as a few of us are on annual leave.
@this-Aditya Please take a look at some comments below.
src/main/java/org/radarbase/management/service/ProjectService.kt
Outdated
Show resolved
Hide resolved
src/main/java/org/radarbase/management/config/OAuth2ServerConfiguration.kt
Outdated
Show resolved
Hide resolved
src/main/java/org/radarbase/management/service/dto/ProjectLiteDTO.kt
Outdated
Show resolved
Hide resolved
src/main/java/org/radarbase/management/service/dto/ProjectLiteDTO.kt
Outdated
Show resolved
Hide resolved
src/main/java/org/radarbase/management/web/rest/ProjectLiteResource.kt
Outdated
Show resolved
Hide resolved
src/main/java/org/radarbase/management/web/rest/ProjectLiteResource.kt
Outdated
Show resolved
Hide resolved
src/main/java/org/radarbase/management/web/rest/PublicResource.kt
Outdated
Show resolved
Hide resolved
src/main/java/org/radarbase/management/service/dto/PublicProjectDTO.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merging for now. We can create separate PRs if changes are needed |
Added a new endpoint for fetching the project data to be used for the self-enrollment portal
Fixes #915