Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes to basic deployment #145

Merged
merged 7 commits into from
Nov 22, 2021
Merged

Fixes to basic deployment #145

merged 7 commits into from
Nov 22, 2021

Conversation

afolarin
Copy link
Member

@afolarin afolarin commented Nov 15, 2021

Description of the change

Changes to the state files & some fixes to some charts & helmfiles.

Benefits

  • Stack deploys with all pods running (though not tested all applications well yet).
  • Stack deploys (also helmfile destroy works now)

Possible drawbacks

none

Applicable issues

Additional information

Checklist

  • Chart version bumped in Chart.yaml according to semver.
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [<name_of_the_chart>])

@github-actions
Copy link

github-actions bot commented Nov 15, 2021

Great PR! Please pay attention to the following items before merging:

Files matching charts/*/values.yaml:

  • Is the PR adding a new container? Please reviewer, add it to the models (internal process)
  • Is the PR adding a new parameter? Please, ensure it’s documented in the README.md

This is an automatically generated QA checklist based on modified files

Copy link
Member

@blootsvoets blootsvoets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for testing!

@blootsvoets blootsvoets merged commit 4b371fb into RADAR-base:main Nov 22, 2021
blootsvoets added a commit that referenced this pull request Dec 21, 2022
Fixes to basic deployment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants