Update postgres #51
Merged
Update postgres #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not using the default values and explicitly defining them in values file helps us mitigate any issues that might occur in case the default values change in the original chart |
|
I guess that’s fine, we just need to update the defaults then, especially the image references are very outdated.
… Op 18 sep. 2020 om 13:22 heeft K1Hyve ***@***.***> het volgende geschreven:
Not using the default values and explicitly defining them in values file helps us mitigate any issues that might occur in case the default values change in the original chart
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
blootsvoets
force-pushed
the
update-postgres
branch
from
c98e2e0
to
2e440f8
Compare
keyvaann
reviewed
Sep 25, 2020
etc/postgresql/values.yaml
Outdated
| replication: | ||
| enabled: true | ||
| user: repl_user | ||
| password: repl_password | ||
| slaveReplicas: 1 | ||
| slaveReplicas: 2 |
There was a problem hiding this comment.
Why do we need 2 slaveReplicas?
There was a problem hiding this comment.
I don’t know if we do... it’s just that the default changed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Old version of postgresql no longer is accepted by recent K8s/Helm. Updated it and commented out any values that are equal to the defaults or that refer to outdated images/charts.