make path-factory configurable #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keyvaann
reviewed
Oct 12, 2020
| # Additional properties | ||
| # properties: {} | ||
| properties: {{ .Values.paths.properties | toYaml | indent 8 | trim }} |
There was a problem hiding this comment.
I'm not sure if this is the correct format, I always struggle and try a few things until one of them works. You can use helmfile template and see if the output is in correct format.
I usually add a | and put them in a new line, might need to use nindent as well.
There was a problem hiding this comment.
@K1Hyve I have tested the latest push with helmfile and it works.
There is already a | on the top of the yaml file. Moving the values expression to a new line fixes the issues.
blootsvoets
pushed a commit
that referenced
this pull request
Dec 21, 2022
make path-factory configurable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make path-factory configurable