Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downloading the binaries through a proxy #30

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ulrichard
Copy link
Contributor

Downloading the binaries through a proxy if either HTTPS_PROXY or HTTP_PROXY environment variable is set.

closes #29

@RCasatta
Copy link
Owner

Are HTTP_PROXY and HTTPS_PROXY a standard and do you have any reference of projects doing something similar (is cargo automatically using those)?

Is HTTP_PROXY only relative to http requests, thus we should need only HTTPS_PROXY?

If we decide to merge this we need to do also for bitcoind crate otherwise you will have the proxy issue anyway

@ulrichard
Copy link
Contributor Author

It is more a widely used convention than a standard.
https://superuser.com/questions/944958/are-http-proxy-https-proxy-and-no-proxy-environment-variables-standard
In my experience, HTTP_PROXY is also used for https if HTTPS_PROXY is not set. Thus I implemented it that way. But it is also possible that this was just with the programs I used, and the majority behaves differently.
There is also the issue with the casing that is not really standardized. I have seen upper case being used more often.

Yes, I realized, that the same is needed also for bitcoind. I'm on it.

@ulrichard ulrichard force-pushed the feature/proxy branch 3 times, most recently from da0b2dd to cc4b179 Compare September 29, 2022 09:18
@RCasatta
Copy link
Owner

still requires rust-bitcoin/bitcoind#49

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Download using http proxy
2 participants