Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): upgrade bitcoind to 0.36.0, bitcoin_hashes to 0.14.0 and electrum-client to 0.20.0 #80

Merged

Conversation

oleonardolima
Copy link
Contributor

@oleonardolima oleonardolima commented May 4, 2024

partially fixes #1422

Description

It updates the bitcoind, electrum-client and the bitcoin_hashes crate dependencies.

NOTE: The overall BDK update to 0.32.0 still requires and depends on some other crates, please refer to #1422.

Notes to the reviewers

It's open for any comments.

Changelog notice

  • Update the bitcoind crate dependency to 0.36.0
  • Update the electrum-client crate dependency to 0.20.0
  • Update the bitcoin-hashes crate dependency to 0.14.0

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

New Features:

  • I've added tests for the new feature
  • I've added docs for the new feature

@oleonardolima oleonardolima force-pushed the deps/upgrade-bitcoind-to-0.36.0 branch 3 times, most recently from df543dd to accf68e Compare May 4, 2024 20:28
@oleonardolima oleonardolima force-pushed the deps/upgrade-bitcoind-to-0.36.0 branch from accf68e to 2c2a918 Compare May 16, 2024 15:00
@oleonardolima oleonardolima changed the title wip(deps): upgrade bitcoind to 0.36.0 and electrum-client to 0.20.0 chore(deps): upgrade bitcoind to 0.36.0 and electrum-client to 0.20.0 May 16, 2024
@oleonardolima oleonardolima marked this pull request as ready for review May 16, 2024 15:01
@oleonardolima oleonardolima force-pushed the deps/upgrade-bitcoind-to-0.36.0 branch from 2c2a918 to a98e4c1 Compare May 27, 2024 18:31
@oleonardolima
Copy link
Contributor Author

@RCasatta It only requires a new release of rust-electrum-client as bitcoindevkit/rust-electrum-client#133 got merged, then this one is ready to go.

cc @notmandatory

@RCasatta
Copy link
Owner

Concept ACK, I am going to merge/publish as soon electrum-client is released and used here

Cargo.toml Outdated Show resolved Hide resolved
@notmandatory
Copy link
Contributor

I just published electrum-client 0.20.0: https://crates.io/crates/electrum-client/0.20.0

@oleonardolima oleonardolima force-pushed the deps/upgrade-bitcoind-to-0.36.0 branch 2 times, most recently from 8a44f46 to bb1c4f2 Compare May 28, 2024 16:52
@oleonardolima oleonardolima force-pushed the deps/upgrade-bitcoind-to-0.36.0 branch from bb1c4f2 to 0892b01 Compare May 28, 2024 16:53
@oleonardolima oleonardolima changed the title chore(deps): upgrade bitcoind to 0.36.0 and electrum-client to 0.20.0 chore(deps): upgrade bitcoind to 0.36.0, bitcoin_hashes to 0.14.0 and electrum-client to 0.20.0 May 28, 2024
Copy link
Owner

@RCasatta RCasatta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 5c58b3d

@RCasatta RCasatta merged commit 0892b01 into RCasatta:master May 29, 2024
9 checks passed
@RCasatta
Copy link
Owner

published on crates.io

@oleonardolima oleonardolima deleted the deps/upgrade-bitcoind-to-0.36.0 branch May 29, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants