compute better filenames for returned rdf #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lalewis1
force-pushed
the
lawson/vocpub-all
branch
from
7296452
to
ffc6ba4
Compare
As per issue idn-au/catalogue-data#35 The returned RDF files did not have appropriate filenames.
lalewis1
force-pushed
the
lawson/vocpub-all
branch
from
ffc6ba4
to
c7a777c
Compare
|
Looks fine - could you add minimal tests to check the header comes back as expected for an object + listing |
tests that the returned headers are as expected for object and listing endpoints
|
Minimal tests added. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per issue idn-au/catalogue-data#35 The
returned RDF files did not have appropriate filenames.
This PR adds a filename where possible to the returned RDF via the
Content-Dispositionheader.