Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: upgrade pyduktape2 #203

Conversation

aucampia
Copy link
Member

@aucampia aucampia commented Sep 4, 2023

This change updates the version of pyduktape2 in pyproject.toml to a version that sets a restriction on the version of CPython. This is needed because pyduktape2 does not build with the latest version of CPython.

This change updates the version of pyduktape2 in pyproject.toml to a
version that sets a restriction on the version of CPython. This is
needed because pyduktape2 does not build with the latest version of
CPython.
@aucampia aucampia marked this pull request as ready for review September 4, 2023 17:51
@aucampia
Copy link
Member Author

aucampia commented Sep 5, 2023

Seems mypy is failing now on python 3.8, 3.10 and 3.11, I will try make a PR to fix that a bit later

@ajnelson-nist
Copy link
Contributor

ajnelson-nist commented Sep 5, 2023

Seems mypy is failing now on python 3.8, 3.10 and 3.11, I will try make a PR to fix that a bit later

@aucampia : I noticed the mypy failures too when I was checking up on pyshacl.validate.validate's signature. I filed PR 192 as an intermediary fix. There will be more to do after that PR if it's merged.

@ashleysommer
Copy link
Collaborator

This PR includes only the updated poetry.lock file. Is it supposed to have the updated pyproject.toml file too?

@aucampia
Copy link
Member Author

aucampia commented Sep 5, 2023

This PR includes only the updated poetry.lock file. Is it supposed to have the updated pyproject.toml file too?

The version range in pyproject.toml already includes the newly released version:

pyduktape2 = {version="^0.4.3", optional=true}

But when poetry installs dependencies it uses the specific versions in poetry.lock:

pySHACL/poetry.lock

Lines 617 to 625 in eda96e1

[[package]]
name = "pyduktape2"
version = "0.4.3"
description = "Python integration for the Duktape Javascript interpreter"
optional = true
python-versions = "*"
files = [
{file = "pyduktape2-0.4.3.tar.gz", hash = "sha256:4444c3c103fd18988b17d22822ac77a8a4c7e602a3122ed3fc93a48732d4f7b2"},
]

So this only updates the locked version. In RDFLib this is updated by Dependabot.

@ashleysommer
Copy link
Collaborator

Yeah, thanks, I thought maybe that is what you were going for.
BTW, I opened a discussion thread about the merits of including a lockfile in PySHACL, and the differing use cases of PySHACL as and Application vs PySHACL as a library.
#204

@ashleysommer ashleysommer merged commit 52e239c into RDFLib:master Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI fails on pyduktape
3 participants