Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

speedup notation3/turtle parser #1272

Merged
merged 5 commits into from
Mar 13, 2021

Conversation

white-gecko
Copy link
Member

@white-gecko white-gecko commented Mar 4, 2021

Fixes #1266, #1270 (replaces).
Fixes #1262.
Related to #1261

@rchateauneu, @FlorianLudwig

Proposed Changes

@white-gecko white-gecko changed the title Feature/speedup n3 speedup notation3/turtle parser Mar 4, 2021
@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 75.515% when pulling 9653eef on white-gecko:feature/speedupN3 into 9f0f296 on RDFLib:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 75.515% when pulling 9653eef on white-gecko:feature/speedupN3 into 9f0f296 on RDFLib:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 75.515% when pulling 9653eef on white-gecko:feature/speedupN3 into 9f0f296 on RDFLib:master.

@white-gecko
Copy link
Member Author

The last thing we were looking for are new tests for the changed lines of the parser, but maybe passing the current tests is ok already, and we make a new pr for additional tests. @nicholascar @ashleysommer what do you think?

@white-gecko
Copy link
Member Author

@nicholascar and @ashleysommer: any objections to merge?

@nicholascar
Copy link
Member

I'm happy for you to merge.

@white-gecko white-gecko merged commit 1b77d03 into RDFLib:master Mar 13, 2021
@white-gecko white-gecko deleted the feature/speedupN3 branch March 13, 2021 08:22
@white-gecko white-gecko added this to the rdflib 6.0.0 milestone Mar 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possible optimisation of notation3.py ?
5 participants