-
Notifications
You must be signed in to change notification settings - Fork 555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
speedup notation3/turtle parser #1272
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 similar comments
Closed
The last thing we were looking for are new tests for the changed lines of the parser, but maybe passing the current tests is ok already, and we make a new pr for additional tests. @nicholascar @ashleysommer what do you think? |
@nicholascar and @ashleysommer: any objections to merge? |
nicholascar
approved these changes
Mar 13, 2021
I'm happy for you to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1266, #1270 (replaces).
Fixes #1262.
Related to #1261
@rchateauneu, @FlorianLudwig
Proposed Changes
[i : i + 1]
with access to chars[i]
while
loop with with find:https://github.com/RDFLib/rdflib/compare/master...white-gecko:feature/speedupN3?expand=1#diff-702447d86f727e47363ffbc864d3cef01dbceee6b0652f0e992c71947324dc95L1202
https://github.com/RDFLib/rdflib/compare/master...white-gecko:feature/speedupN3?expand=1#diff-702447d86f727e47363ffbc864d3cef01dbceee6b0652f0e992c71947324dc95R1201
skipSpace()
char in "abc"
withchar in {'a', 'b', 'c'}
constructs (set instead of string)