Made ClosedNamespace (and _RDFNamespace) inherit from Namespace #551
Conversation
|
ERROR: Failure: RuntimeError (maximum recursion depth exceeded in cmp) |
gromgull
force-pushed
the
closednamedspace-inheritance-fix
branch
from
7d4f738
to
bccc761
Compare
|
Now only the test broken by SPARQLWrapper unicode thingy breaks :) |
| @property | ||
| def title(self): | ||
| return URIRef(self + 'title') | ||
|
|
There was a problem hiding this comment.
No idea, nothing broke when I removed it :)
There was a problem hiding this comment.
I think it was to make this:
>>> from rdflib.namespace import DCTERMS
>>> DCTERMS.title
result in:
rdflib.term.URIRef(u'http://purl.org/dc/terms/title')
instead of:
u'Http://Purl.Org/Dc/Terms/'
There was a problem hiding this comment.
So it should be added back (along with a test) since existing code will break otherwise.
There was a problem hiding this comment.
will do... too quick with that one...
There was a problem hiding this comment.
Note: the title method won't be called (of course), but the value will be <built-in method upper of Namespace object at ...> instead of (e.g.) dcterms:title.
(This is a general gotcha with the Namespace utility colliding with unicode method names of course, and I guess it would be more ideal if it used __getattribute__ to never return bound methods.)
There was a problem hiding this comment.
it's to override this:
In [7]: unicode('foo').title()
Out[7]: u'Foo'There was a problem hiding this comment.
maybe we should just not subclass unicode?
There was a problem hiding this comment.
for now added it back + test for DCTERMS.title... in master already
There was a problem hiding this comment.
Great, thanks! I jotted down the other thoughts in #556.
Made ClosedNamespace (and _RDFNamespace) inherit from Namespace
|
patched with ae1f639 to allow |
|
"Fixing" this actually broke a bit of random code for me - I used to rely on |
|
@gromgull i don't understand, it doesn't for me: In [1]: import rdflib
INFO:rdflib:RDFLib Version: 4.2.2-dev
In [2]: rdflib.namespace.DCTERMS
Out[2]: Namespace(u'http://purl.org/dc/terms/')
In [3]: rdflib.namespace.DCTERMS.title
Out[3]: rdflib.term.URIRef(u'http://purl.org/dc/terms/title') |
|
The problem comes from ClosedNamespace: In [117]: c=ClosedNamespace('http://example.org/','count')
In [118]: c.count
Out[118]: <function count>
In [119]: :(previously this worked, since ClosedNamespace did not inherit from unicode |
|
ok, i'll roll this back for the 4.2.2 release and move it to 5.0.0 |
This fixes #542