Implemented reading RI from CSV data for PandasData #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed branch limitation from CI
maximskorik
approved these changes
Jun 29, 2021
| @@ -44,13 +44,17 @@ def _init_rt_column_info(self): | |||
| def _init_ri_column_info(self): | |||
| """ Initialize retention index column name and set its position next to the retention time column. """ | |||
| self._ri_index = 'retention_index' | |||
| self._ri_position = self._rt_position + 1 | |||
| if self._ri_index in self._data.columns: | |||
| self._ri_position = self._data.columns.get_loc(self._ri_index) | |||
There was a problem hiding this comment.
That looks nice, I've had no idea something like get_loc existed.
There was a problem hiding this comment.
This is only for Pandas data frames. Found it in the documentation here.
There was a problem hiding this comment.
yup, I checked it out already :)
martenson
reviewed
Jun 29, 2021
| @@ -7,6 +7,7 @@ | |||
| class PandasData(Data): | |||
| """ Class to handle data from filetypes which can be imported into a pandas dataframe. """ | |||
| _rt_column_names = set(['RT', 'rt', 'rts', 'retention_times', 'retention_time', 'retention', 'time']) | |||
| _ri_column_names = set(['RI', 'ri', 'ris', 'retention_indices', 'retention_index', 'kovats', 'retentionindex']) | |||
There was a problem hiding this comment.
let's start a new standard to unite them all🤣
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #30
Also introduces multiple possible names for the RI column.