Add setters for PandasData and MatchMSData #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maximskorik
changed the title
hechth
changed the title
hechth
requested changes
Apr 16, 2021
hechth
approved these changes
Apr 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4
PandasData:
_set_rt_index()to_set_rt_index_n_position(). Besides fetching RT column name it now fetches its numerical index.retention_indices()to return column with RIs if exists.retention_indices()- after comparing RIs list/tuple length to length of features puts RIs in a new column next to RTs.MatchMSData:
retention_indices()- after after comparing RIs list/tuple length to length of features adds RI to metadata attribute of Spectra object. After exporting metadata back to.mspRI will appear as the last item of metadata. I'd like to put it after RT, but don't have an idea yet how to do that without cryptic code like this.Closes #4