signal-to-noise separated into ratio and noise in IsoFiltR #594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hechth
reviewed
Oct 17, 2024
hechth
approved these changes
Oct 17, 2024
|
@KristinaGomoryova is this the only tool where this was still combined? Or aren't there more of them yet? |
|
Well, this is somewhat related RECETOX/MFAssignR#63 |
|
Please make the same changes also to the SNplot tool where we currently have the cutoff value as a single parameter. |
Resolved in cc5048d |
hechth
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signal-to-ratio parameter is now separated into
kmdn*SN_ratiosimilarly as it's done in other functions (e.g. MFAssign).closes #588