Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moving NumPy into PE102 where it belongs. #30

Merged
merged 1 commit into from
May 21, 2024
Merged

moving NumPy into PE102 where it belongs. #30

merged 1 commit into from
May 21, 2024

Conversation

erikscott
Copy link
Collaborator

PE101 is for packages in general and conda. Moved to PE102 Numerical analysis.

@erikscott erikscott merged commit c44d69e into main May 21, 2024
1 check passed
@sajith
Copy link
Member

sajith commented May 22, 2024

We also need a way to navigate to this file, either by editing /index.md or renaming this file (with git mv -f theme1/PE102/PE102-02NumPy.ipynb theme1/PE102/numerical-data-analysis.ipynb).

We also need a way to render the cells when deploying to the site. We'll need numpy and matplotlib on CI. I will take care of that.

@sajith
Copy link
Member

sajith commented May 22, 2024

Actually, Quarto will not execute the notebooks by default because "the presumption being that you have already executed them while editing the notebook".

https://quarto.org/docs/projects/code-execution.html#notebooks

There are execution errors in https://github.com/RENCI-NRIG/X-CITE/blob/main/theme1/PE102/PE102-02NumPy.ipynb. We should re-run the notebook locally again, fixing those errors, and commit those changes.

@erikscott
Copy link
Collaborator Author

erikscott commented May 22, 2024 via email

@sajith
Copy link
Member

sajith commented May 22, 2024

It should not be a problem if we've executed cells in the notebook locally. If we want, we can install numpy and matplotlib on CI, and get the workflows to execute them on CI. But that is not really necessary, at least right now.

@erikscott
Copy link
Collaborator Author

erikscott commented May 22, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants