Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update read more section styles #74

Merged
merged 2 commits into from
Dec 4, 2023
Merged

Conversation

suejinkim20
Copy link
Collaborator

align heading and ul styles between individual person page and individual article page

@suejinkim20 suejinkim20 requested a review from Woozl December 4, 2023 20:30
Copy link
Member

@Woozl Woozl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. On a related note, some of the older news pages don't have any linked types, but still display an empty "Read More" section. Could we have that be conditionally rendered based on whether there's any content?

Example: /news/2005/12/20/renci-blatecky-lauded-for-outstanding-service

@suejinkim20
Copy link
Collaborator Author

Looks good. On a related note, some of the older news pages don't have any linked types, but still display an empty "Read More" section. Could we have that be conditionally rendered based on whether there's any content?

Example: /news/2005/12/20/renci-blatecky-lauded-for-outstanding-service

good point! it's now conditionally rendered!

@suejinkim20 suejinkim20 merged commit be01540 into develop Dec 4, 2023
@suejinkim20 suejinkim20 deleted the update/read-more-section branch June 6, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants