Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add author list to article #75

Merged
merged 2 commits into from
Dec 7, 2023
Merged

add author list to article #75

merged 2 commits into from
Dec 7, 2023

Conversation

Woozl
Copy link
Member

@Woozl Woozl commented Dec 5, 2023

There's probably a better way to do this... but it's a first start, any feedback is welcome. Unfortunately we're hitting that 7 depth GQL limit again so I have to waterfall request the images after the article response comes back. Although I guess this will be changed by the move to the dashboard as well.

image

@Woozl Woozl requested review from mbwatson and suejinkim20 December 5, 2023 18:56
@mbwatson
Copy link
Member

mbwatson commented Dec 6, 2023

👍 very cool! this seems like a great approach to me.

the authors' photos beside their names is a nice touch. why not use MUI's Avatar component here instead of your customized Box?

@Woozl
Copy link
Member Author

Woozl commented Dec 6, 2023

@mbwatson swapped to Avatar component. I don't think it makes sense to have the initials for the external authors, in my opinion that makes it seem like a profile that can be clicked.

@suejinkim20
Copy link
Collaborator

@mbwatson swapped to Avatar component. I don't think it makes sense to have the initials for the external authors, in my opinion that makes it seem like a profile that can be clicked.

this makes sense, and i agree with you david. in the future, it might be nice to link to an individual's linked-in or professional website, but that would require a completely different externalAuthors data type, since it's currently just an open-ended string.

Copy link
Collaborator

@suejinkim20 suejinkim20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks great 👍🏼

@Woozl Woozl merged commit a0da720 into develop Dec 7, 2023
@Woozl Woozl deleted the update/add-authors-to-article branch December 7, 2023 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants