Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chrome 72: Extension non-functional #154

Closed
moderndeveloperllc opened this issue Jan 30, 2019 · 13 comments
Closed

Chrome 72: Extension non-functional #154

moderndeveloperllc opened this issue Jan 30, 2019 · 13 comments

Comments

@moderndeveloperllc
Copy link

@esphen It looks like Chrome 72 has broken things a bit:

Uncaught (in promise) TypeError: Illegal invocation: Function must be called on an object of type StorageArea
    at rested.js:29
    at new Promise (<anonymous>)
    at new t (rested.js:6)
    at i (rested.js:29)
    at e.<anonymous> (rested.js:29)
    at o (rested.js:29)
    at Generator._invoke (rested.js:29)
    at Generator.e.(anonymous function) [as next] (chrome-extension://eelcnbccaccipfolokglfhhmapdchbfg/dist/rested.js:29:19339)
    at r (rested.js:29)
    at rested.js:29

Based on this bug fix on a different repo, it looks like an issue with Promises and handling the async calls. Another extension had this issue too.

@eliihen
Copy link
Member

eliihen commented Jan 30, 2019

Interesting. I wasn't aware. Thanks for the heads up.

The linked issues are a great place to start looking. I probably won't have time to dig in until next week, but feel free to have a look in the mean time if you want to help out ✌️

@PeteDaGuru
Copy link

Yeah, this hit me on my latest upgrade -.v 72.0.3626.81 . Thankfully, it still works on Firefox!
Oh, and thank you for such a nice lightweight client!

@filipesperandio
Copy link

Came across this while search for this error on my extension.
Turns out an quick fix is to bind the functions back to its holding object like:
chrome.storage.sync.get.bind(chrome.storage.sync)

@KeithHenry
Copy link

Now fixed in https://www.npmjs.com/package/chrome-extension-async version 3.3.1, apologies for the delay.

@eliihen
Copy link
Member

eliihen commented Feb 8, 2019

I'm having issues reproducing this issue. Despite my best efforts in Chrome, it seems to work just fine. Very strange. I don't see why my Chrome 72.0.3626.81 should be different to yours.

Are you able to reproduce the issue with a clean chrome profile? Any steps to reproduce from there?

@garry-kevin
Copy link

garry-kevin commented Feb 8, 2019

I'm having issues reproducing this issue. Despite my best efforts in Chrome, it seems to work just fine. Very strange. I don't see why my Chrome 72.0.3626.81 should be different to yours.

Are you able to reproduce the issue with a clean chrome profile? Any steps to reproduce from there?

Using Chrome 72.0.3626.81. Showing this error now.
Screenshot

@zuxianghuang
Copy link

chrome Version 73.0.3683.75 (Official Build) (64-bit)
have the same problem
image

@avonwyss
Copy link

Getting the same problem with Chrome 74.0.3729.108

@csimi
Copy link
Contributor

csimi commented Jun 14, 2019

@esphen please check the pr referencing this issue above as the bug for this is from that repo

@Jotune
Copy link

Jotune commented Jul 12, 2019

Same problem with Opera 62.0.3331.72

eliihen pushed a commit that referenced this issue Jul 23, 2019
closes #154 update localforage-webextensionstorage-driver
@eliihen eliihen mentioned this issue Jul 23, 2019
@eliihen
Copy link
Member

eliihen commented Jul 23, 2019

The PR @csimi was referring to was merged today and 2.3.1 was just released, should be rolling out soon. Hope that fixes the issue.

The opera developer portal seems to be down at this time, so I have not been able to upload there yet unfortunately. Will keep trying.

@eliihen
Copy link
Member

eliihen commented Jul 23, 2019

Submitted for Opera as well now

@csimi
Copy link
Contributor

csimi commented Jul 23, 2019

I can confirm that it works in Chrome again.
Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

10 participants