Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.1.0 #108

Merged
merged 14 commits into from
Jul 29, 2017
Merged

2.1.0 #108

merged 14 commits into from
Jul 29, 2017

Conversation

eliihen
Copy link
Member

@eliihen eliihen commented Jul 26, 2017

Release of 2.1.0

Featues

Fixes

eliihen added 4 commits May 26, 2017 07:16
This allows support for viewing redirected requests (#84)
This works around a CORS issue with headers in Chrome (#104)
- Adds request body presets
- Sets the default preset to JSON (#103)
- Persists the user's previously selected preset for
  new requests (#88)
- Sets the request body to be expanded by default (#78)
- Fixes the `Content-Type` header not being visible in the
  headers list (#75)
@coveralls
Copy link

Coverage Status

Coverage decreased (-3.09%) to 59.623% when pulling 5f64d83 on next into cae9723 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-3.06%) to 59.655% when pulling b1ddd6c on next into cae9723 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.8%) to 61.931% when pulling 2bc4e13 on next into cae9723 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+2.5%) to 65.176% when pulling 28f57fc on next into cae9723 on master.

@eliihen
Copy link
Member Author

eliihen commented Jul 26, 2017

Just published the first release candidate, 2.1.0-rc.1. I added compiled extension files there, please test!

cc @moderndeveloperllc

@moderndeveloperllc
Copy link

moderndeveloperllc commented Jul 26, 2017

@esphen Switching Request Body Type to Custom (Method - POST) gives me this error:

uncaught at r 
 at v 
 at i 
 at g 
 Error: Body type custom is not supported
    at chrome-extension://efhficcaphambolcidkajacbepebblnj/dist/rested.js:29:509985
    at o (chrome-extension://efhficcaphambolcidkajacbepebblnj/dist/rested.js:29:18787)
    at Generator._invoke (chrome-extension://efhficcaphambolcidkajacbepebblnj/dist/rested.js:29:20196)
    at Generator.e.(anonymous function) [as next] (chrome-extension://efhficcaphambolcidkajacbepebblnj/dist/rested.js:29:18966)
    at b (chrome-extension://efhficcaphambolcidkajacbepebblnj/dist/rested.js:26:11564)
    at n (chrome-extension://efhficcaphambolcidkajacbepebblnj/dist/rested.js:26:12305)
    at I (chrome-extension://efhficcaphambolcidkajacbepebblnj/dist/rested.js:26:15554)
    at E (chrome-extension://efhficcaphambolcidkajacbepebblnj/dist/rested.js:26:13149)
    at b (chrome-extension://efhficcaphambolcidkajacbepebblnj/dist/rested.js:26:11624)
    at l (chrome-extension://efhficcaphambolcidkajacbepebblnj/dist/rested.js:26:17001)

FWIW, I was able to use the JSON type well. Perhaps using that as a Body Type would also set the Content-Type header to application/json if a different one wasn't already set? Just a thought.

@moderndeveloperllc
Copy link

I also see (in Opera) the extension still having a 2.0.4 version number. Not sure if that will change when you release, or if that's an oversight.

@eliihen
Copy link
Member Author

eliihen commented Jul 26, 2017

Switching Request Body Type to Custom (Method - POST) gives me this error

Thanks! I'll fix that

FWIW, I was able to use the JSON type well. Perhaps using that as a Body Type would also set the Content-Type header to application/json if a different one wasn't already set? Just a thought.

It should already do that. If it doesn't, that's a bug. I can reproduce this when I go to the custom type and back. I'll fix this too.

I also see (in Opera) the extension still having a 2.0.4 version number. Not sure if that will change when you release, or if that's an oversight.

Yeah, I saw that right after I published the rc. It's an oversight I'll fix in the next release, but it shouldn't matter that much.

Thanks for helping test, it is very much appreciated!

@moderndeveloperllc
Copy link

Getting all the Response headers back looks to be working great. I'm noticing the Content-Type issue with POSTs it seems.

@coveralls
Copy link

Coverage Status

Coverage increased (+2.3%) to 65.047% when pulling 99f140f on next into cae9723 on master.

@eliihen
Copy link
Member Author

eliihen commented Jul 27, 2017

2.1.0 RC 3 is out!

@moderndeveloperllc Does it look better now? Could you also please test a redirect request (like https://httpbin.org/redirect/6) and an https redirect (like http://news.ycombinator.com) and see if they are visible above the response?

@coveralls
Copy link

Coverage Status

Coverage increased (+2.3%) to 65.047% when pulling e5fddd2 on next into cae9723 on master.

@moderndeveloperllc
Copy link

@esphen The redirects are working great for me. Will the collections transfer over if I update in place? Installing them side by side the 2.1 extension doesn't have the 18 or so I've created.

@eliihen
Copy link
Member Author

eliihen commented Jul 28, 2017

Will the collections transfer over if I update in place?

Yes, there is no reason why they shouldn't. Have a look in the URL - if the URL is different in 2.1 than in 2.x, then that is why there is no collections there. When updating, the ID will not change, but I guess there is no guarantee that it will stay the same when you install manually.

@eliihen eliihen merged commit 9f44b40 into master Jul 29, 2017
@eliihen
Copy link
Member Author

eliihen commented Jul 29, 2017

Published and awaiting review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants