Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make syntax highlighting size limit configurable #219

Conversation

ChiefOfGxBxL
Copy link
Contributor

image

image

The previous value was hard-coded at 20KB, but the user can now configure this limit

Syntax highlighting incurs a performance penalty, but that will be dependent on user preference

Closes #171
Closes #74

The previous value was hard-coded at 20KB, but the user can now configure this limit

Syntax highlighting incurs a performance penalty, but that will be dependent on user preference

Closes RESTEDClient#171
Closes RESTEDClient#74
@eliihen eliihen added this to the 2.5.0 milestone Dec 6, 2021
@eliihen eliihen merged commit e412e49 into RESTEDClient:master Dec 6, 2021
@eliihen
Copy link
Member

eliihen commented Dec 6, 2021

I find no issues with this PR, well done! This has been a highly requested feature, so great to see it implemented 😁

I'll release 2.5 this weekend, probably like sunday. If you keep on submitting patches then I'll try to do a release every week, so feel free to keep sending PRs 🙂

@ChiefOfGxBxL
Copy link
Contributor Author

ChiefOfGxBxL commented Dec 6, 2021

@esphen Happy to help! I've been using RESTED for both personal projects and in the workplace, so thanks for making the tool. I have a few more ideas I'll be playing around with.

@eliihen eliihen mentioned this pull request Dec 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

20KB syntax highlighting Allow increasing syntax highlighting limit?
2 participants