Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to see WebView buttons when running Shiny app #501

Closed
rpodcast opened this issue Dec 22, 2020 · 3 comments
Closed

Unable to see WebView buttons when running Shiny app #501

rpodcast opened this issue Dec 22, 2020 · 3 comments
Labels

Comments

@rpodcast
Copy link

Describe the bug

I wanted to try the new browser WebView command buttons that were recently added via PR #494 in a remote container session, but I do not see the buttons appear in the VS-Code UI when running a shiny application

To Reproduce
Steps to reproduce the behavior:

  1. Create a development environment container for VS-Code using a custom .devcontainer/devcontainer.json and DockerFile such as the configuration in this GitHub repository
  2. If not present, install the shiny package and run the example application in an R terminal via shiny::runExample("01_hello")
    3 View the tab of the application which only shows two buttons (default to split to side view and the "...")

Do you want to fix by self? (I hope your help!)

I would be glad to help troubleshoot further but I don't have enough expertise to fix myself

Expected behavior

Ability to refresh webview and open in external browser with new buttons

Screenshots

2020-12-22_00-09

Environment (please complete the following information):

  • OS: Linux Ubuntu 20.04
  • VSCode Version: 1.52.1 (snap package)
  • R Version: 4.0.2 (running in development docker container)
  • vscode-R version: 1.6.2 (installed in remote session)

Additional context

It was not clear to me if I was supposed to set any new configuration options either in the extension or within the languageserver package itself.

@rpodcast rpodcast added the bug label Dec 22, 2020
@renkun-ken
Copy link
Member

renkun-ken commented Dec 22, 2020

Could you confirm that you installed the latest development build in the remote session since it is not released yet?

@rpodcast
Copy link
Author

That indeed was the issue. I had assumed incorrectly that this was part of the latest version in the extension marketplace. I had to look up how to install a development .vsix version of an extension but found this post on how to pull it off. After rebuiliding the container I can see the buttons without a problem. We can close this. Just for my understanding, how do we tell if the version available on the marketplace is behind the current GitHub version?

@ManuelHentschel
Copy link
Member

Just for my understanding, how do we tell if the version available on the marketplace is behind the current GitHub version?

Ideally, the latest release in the releases section is identical to the marketplace release. There you can also view the commits to master since the release and check if something relevant changed.

Currently the GitHub release action is not happening (completely) automatically, so the last release wasn't released on github in time.
I'll open a separate Issue/PR to address this and hopefully the next releases will be mirrored on GitHub automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants