Add browser WebView command buttons #494
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem did you solve?
This PR adds the following buttons to WebViews created by
browser
.Also, this PR uses
vscode.env.asExternalUri
introduced at https://code.visualstudio.com/api/advanced-topics/remote-extensions#forwarding-localhost instead of port mapping. Now the port forwarding should work smoothly under remote development when a browser WebView is created without relying on explicit port mapping (currently not working, see microsoft/vscode#102449) and auto port forwarding (currently not working smoothly, see microsoft/vscode#112297).(If you have)Screenshot
(If you do not have screenshot) How can I check this pull request?
shiny::runExample("01_hello")
and a WebView is created"Open in external browser" should also work under remote development as it will automatically setup the port forwarding from remote to local. To test, just repeat the above steps under remote development and the behavior should be exactly the same.