Add missing binding methods #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zoedberg
requested changes
Oct 7, 2024
There was a problem hiding this comment.
Thanks! We'll merge this as soon as you make the requested changes and its counterpart PR gets merged and a new rgb-lib version with that changes will be released (we'll do this as quickly as we can).
Please sort the methods, format the code (npm run format), rebase the commit on top of master and sign it.
It would be awesome if you could also call the methods in the example file, but that's not mandatory.
tmalahie
force-pushed
the
wrapper-additions
branch
3 times, most recently
from
1fdb945
to
827866f
Compare
|
We released rgb-lib 0.3.0-alpha.9 (which includes RGB-Tools/rgb-lib#49). |
tmalahie
force-pushed
the
wrapper-additions
branch
2 times, most recently
from
cff609a
to
80ba737
Compare
tmalahie
force-pushed
the
wrapper-additions
branch
from
80ba737
to
bcfe295
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a few more methods to the wrapper library. I'm currently integrating a wallet in Node.js and I needed them to benefit of all the RGB features. The new methods include:
This PR depends on this one in rgb-lib repo: RGB-Tools/rgb-lib#49