Preserve historic state for reorgs and unmined witness txes #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dr-orlovsky
requested review from
cryptoquick,
crisdut,
nicbus,
zoedberg and
fedsten
This was referenced Jul 8, 2023
zoedberg
approved these changes
Jul 8, 2023
There was a problem hiding this comment.
I confirm that this PR, along with RGB-WG/rgb-std#81, solves RGB-WG/rgb-std#80 and RGB-WG/rgb-std#81 (comment).
While executing rgb-lib tests I've found a test that fails in a non-deterministic way with a Lnpbp4Mismatch error. But I checked and it happens also without these PRs, so I'll open a dedicated issue for that. In the meantime I think these PRs can be merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes RGB-WG/rgb-std#81 (comment)
In simple terms, we were removing previous state from the contract state data once we add a new state transition. However, this new state transition may not be yet final (its witness transaction is not mined), or may become invalid due to a blockchain re-org. Thus, I suggest to keep the historic state here (wallets do filter it anyway, so if it is assigned to a tx output which is already spent it will not be shown to the user).
Since the historic data will accumulate over the time, I plan to add an API to prune them with the wallet deciding which witness transactions are deep enough to safely remove the state.