-
-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test function to validate Transition node ID immutability #18
Conversation
Not sure why it has not run any CI. Am I right that currently this test fails? |
Yes, you are correct. The changes that you have implemented are incomplete. I have been trying to warn you guys about it for a while. For one thing, the If you look at my original PR (#6) you will see that the |
The part on the RGB Core is WIP, so yes, it is incomplete. And I see no other way of meeting all spec requirements from https://github.com/LNP-BP/LNPBPs/discussions/88 other than this. The marker trait you proposed does not solve linearization problem for nested tree maps, and also we need to introduce proper merkle tree node tagging. |
Closed & reopened in attempt to make CI work and see that it fails on this test |
Ouch, I see, the PR is against non-master, that's why CI is not running. Can you pls do another PR against master so we can see that the master does not pass this test (meaning that the test is correct)? |
@dr-orlovsky, I was not referring to the proposed change to the It should be using the |
@claudiosdc Thanks for pointing that out, Anyway, #8 is finalized now, you are welcome to review (however it is rather large and complex, addressing many other issues than just node_id mutability). |
I propose the addition of a new test function to
contract::nodes
module to help validate the solution for the Transition node ID mutability.