fix: fix maven exhortignore #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zvi Grinberg <zgrinber@redhat.com>
…ts - part 2 Signed-off-by: exhort-java-api-tester <tester@exhort-java-api.com>
…EXHORT_DEV_MODE Property/Environment Variabe Signed-off-by: exhort-java-api-tester <tester@exhort-java-api.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix: Fix bug of artifacts being commented with exhortignore comment in pom.xml are included in sbom generation and thus also in reports , happens both in stack analysis and component analysis for maven.
feat: add mechanism to determine exhort backend URL address based on EXHORT_DEV_MODE Property/Environment Variable , by default it'll be prod exhort URL.
Checklist
Additional information
For stack analysis, it seems that mvn:dependency internal parameter excludes (passed as -Dexcludes=[list_of_deps] ) is not working at all in various cases, althgouh the command is built correctly, hence drop the usage of this non working feature and hanlded it differently in this Change.