feat: set environment variables when executing commands #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xieshenzh
force-pushed
the
mvn-npm-env
branch
2 times, most recently
from
e5872ac
to
89ccbee
Compare
xieshenzh
force-pushed
the
mvn-npm-env
branch
2 times, most recently
from
178355d
to
4bdb541
Compare
|
@zvigrinberg @ilan-pinto please review this PR. It is required by the intellij plugin PR: redhat-developer/intellij-dependency-analytics#128 |
zvigrinberg
approved these changes
Sep 14, 2023
There was a problem hiding this comment.
@xieshenzh lgtm.
It indeeds extending the customization of the package managers' dependencies/platforms.
Please pay attention that i released yesterday a new release version for java-api.
so we advanced to new development iteration - 0.0.2-SNAPSHOT. so after merging this, this feature of yours will be included in that version, and you need to bump it in your build.gradle file.
Thanks.
xieshenzh
force-pushed
the
mvn-npm-env
branch
from
4bdb541
to
9fb0bcb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Modify the java-api to use environment variables like JAVA_HOME and PATH set by the client, when executing the mvn and npm cli.
Without these environment variables, mvn or npm could fail to execute.
Related issue (if any): fixes #issue_number_goes_here
Checklist
Additional information