fix: several bug fixes and improvements #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
September 14, 2023 08:50
Signed-off-by: Zvi Grinberg <tester@exhort-java-api.com>
…or tests Signed-off-by: Zvi Grinberg <tester@exhort-java-api.com>
… manifests from existing directories fix: add correct error handling for cases in which exhort backend returns errors Signed-off-by: Zvi Grinberg <tester@exhort-java-api.com>
…gument test: modify UT and IT tests to take into account failures also, by mocking the http status code to 200 Signed-off-by: Zvi Grinberg <tester@exhort-java-api.com>
zvigrinberg
force-pushed
the
fix-npm-pwd-to-temp
branch
from
f49f8c3
to
52ad13b
Compare
xieshenzh
approved these changes
Sep 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix: component analysis sometimes fails to invoke npm ls because of improper location of temp file creation
test: modify UT and IT tests to take into account failures also, by mocking the http status code to 200
feature: add new component analysis method to enable passing existing manifests from existing directories
test: add tests for new component analysis method with string path argument
fix: add correct error handling for cases in which exhort backend returns errors
Checklist
Additional information