fix: ci tests failure #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zvigrinberg
approved these changes
Oct 24, 2023
There was a problem hiding this comment.
@xieshenzh
Thanks, it's a known issue with npm ( from time to time you need to update tests)
Anyway in the future i'll mock the intractions with npm so the npm listing will be permanenet, and it will save us from updating the expected sboms from time to time.
lgtm, approved, kindly merge whenever you can.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix CI tests failure.
Related issue (if any): fixes #issue_number_goes_here
Checklist
Additional information