-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added support for gradle #99
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @olavtar
Please look at the Comments.
the mocks stubbing in the tests should be adjusted in order that the tests will be successful
also there are some minor changes in the code.
In addition, i saw also problem with the comparison between expected and actual stack analysis sbom - https://github.com/RHEcosystemAppEng/exhort-java-api/actions/runs/8441141382/job/23119617921#step:8:747, please check to reveal the cause for that.
anyway, good job!.
src/test/java/com/redhat/exhort/providers/Gradle_Provider_Test.java
Outdated
Show resolved
Hide resolved
As discussed and agreed, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @olavtar , So it's not only the expiration of the exhort backend that failed the Integration tests, you should also create a minimal simple build.gradle file (maximum 2-3 dependencies), and put it in a new directory gradle in src/test/resources/tst_manifests/it/gradle , like all other package managers. if you need to add properties file, also add it, and also load this file to the IT test only if it's gradle package manager. please try to do the build.gradle with minimum number of dependencies and without any other files dependencies ( maybe only properties file if you have to), Thanks.
This will prevent the nullPointerException that happening in IT Tests.
Signed-off-by: Olga Lavtar <olavtar@redhat.com>
Signed-off-by: Olga Lavtar <olavtar@redhat.com>
Signed-off-by: Olga Lavtar <olavtar@redhat.com>
Signed-off-by: Olga Lavtar <olavtar@redhat.com>
Signed-off-by: Olga Lavtar <olavtar@redhat.com>
Signed-off-by: Olga Lavtar <olavtar@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@olavtar
Looks pretty good. ( now all tests passing including IT )
Just relate to my 2 minor comments.
and i didn't see documentation of gradle in README.md ( configuration, exhortignore for gradle with example, and etc.)
Signed-off-by: Olga Lavtar <olavtar@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@olavtar LGTM, Approved.
Great Job! and thanks for your efforts.
you can merge whenever you ready.
Zvi.
Description
Related issue (if any): fixes #issue_number_goes_here
Checklist
Additional information