Implement remaining Remote Offline Store methods #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmihalac
force-pushed
the
implement-remaining-offline-methods
branch
from
0579e59
to
cf38149
Compare
|
can you install these pre hook commit Also you can do this from makefile |
tmihalac
force-pushed
the
implement-remaining-offline-methods
branch
from
cf38149
to
cdcd3b1
Compare
tmihalac
force-pushed
the
implement-remaining-offline-methods
branch
from
e91c2c4
to
2bff007
Compare
tmihalac
changed the title
dmartinol
reviewed
Jun 6, 2024
dmartinol
reviewed
Jun 6, 2024
dmartinol
reviewed
Jun 6, 2024
dmartinol
reviewed
Jun 6, 2024
dmartinol
reviewed
Jun 6, 2024
dmartinol
reviewed
Jun 6, 2024
dmartinol
reviewed
Jun 6, 2024
dmartinol
reviewed
Jun 6, 2024
dmartinol
reviewed
Jun 6, 2024
dmartinol
reviewed
Jun 6, 2024
dmartinol
reviewed
Jun 6, 2024
dmartinol
reviewed
Jun 6, 2024
dmartinol
reviewed
Jun 6, 2024
redhatHameed
force-pushed
the
remote_offline
branch
2 times, most recently
from
1c5307d
to
a14cd59
Compare
|
@tmihalac required rebase with branch remote_offline |
…ight server and client Signed-off-by: Abdul Hameed <ahameed@redhat.com>
Signed-off-by: Abdul Hameed <ahameed@redhat.com>
use feature_view_names to transfer feature views and remove dummies
…ight server and client Signed-off-by: Abdul Hameed <ahameed@redhat.com>
Signed-off-by: Theodor Mihalache <tmihalac@redhat.com>
Signed-off-by: Theodor Mihalache <tmihalac@redhat.com>
Signed-off-by: Theodor Mihalache <tmihalac@redhat.com>
tmihalac
force-pushed
the
implement-remaining-offline-methods
branch
from
2bff007
to
a2dbfa2
Compare
|
@redhatHameed, @dmartinol rebased and implemented proposed changes |
redhatHameed
reviewed
Jun 7, 2024
dmartinol
reviewed
Jun 7, 2024
Signed-off-by: Theodor Mihalache <tmihalac@redhat.com>
tmihalac
force-pushed
the
implement-remaining-offline-methods
branch
from
124ab2e
to
6d22f18
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Added missing implementations of remaining offline store apis
Which issue(s) this PR fixes:
Addresses #4032
Notes
From now on, all new repositories created with
feast initorfeast init -t localthe Default FeatureService nameddriver_activity_v1will have logging_config parameter initializedThe tests for the offline stores where changed to support the Remote Offline Store, that means that entities like FactService and DataSource should be applied to the registry before calling the remote api calls since the Remote Offline Store server relays on them to be in the registry